Skip to content

Conversation

@erica
Copy link
Contributor

@erica erica commented Mar 10, 2016

The review of SE-0039 "Modernizing Playground Literals" ran from Mar 7…9, 2016. The proposal has been accepted with modifications:

  • The community and core team uniformly agree that this proposal increases uniformity in the swift language.
  • We discussed how to rationalize naming and capitalization of identifiers in the “#” namespace and prefer to move to a model where it uses lower camel case.
  • The argument label on imageLiteral should be “resourceName” to describe the role of the string and avoid needless words, following the naming guidelines from SE-0006.

As such, the preferred spelling of these literals are:

#colorLiteral(red: 0, green: 0, blue: 0, alpha: 0)
#imageLiteral(resourceName: “foo")
#fileLiteral(resourceName: “bar”)

DougGregor added a commit that referenced this pull request Mar 11, 2016
updated SE-0039 playground proposal to match core team feedback
@DougGregor DougGregor merged commit 24205cb into swiftlang:master Mar 11, 2016
@lattner
Copy link
Collaborator

lattner commented Mar 11, 2016

@erica and @DougGregor, I'm not sure if merging this was a good idea. Before this PR, I updated the proposal to directly reflect the decision. I think we either need to revert that patch, or revert this one. What do you prefer?

@DougGregor
Copy link
Member

Sorry, I missed your update. I think it's fine to revert this merge, but it would be good to have a link to the "Accepted" e-mail (which describes the changes and why) so there is some history there.

@erica
Copy link
Contributor Author

erica commented Mar 11, 2016

I'm fine reverting the merge.

@erica erica deleted the updatedPlayground branch March 11, 2016 17:07
@lattner
Copy link
Collaborator

lattner commented Mar 11, 2016

Ok, I'll try to figure out how to revert this, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants